Remove invalid @staticmethod from module-level get_device_and_memory_breakdown#41747
Merged
albertvillanova merged 1 commit intohuggingface:mainfrom Oct 22, 2025
Conversation
Member
Author
|
If approved, this fix may need being backported to v4.57-release branch, which still supports Python 3.9. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
remi-or
approved these changes
Oct 20, 2025
Collaborator
remi-or
left a comment
There was a problem hiding this comment.
Thanks for fixing! This was quite ugly.
Contributor
|
cc @ArthurZucker @Cyrilvallez in case we have another patch for v4, I added a for patch label |
Member
Author
|
Thanks, @vasqu. As I commented above: #41747 (comment)
|
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
…y_breakdown (huggingface#41747) Remove staticmethod decorator from function
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
…y_breakdown (huggingface#41747) Remove staticmethod decorator from function
Cyrilvallez
pushed a commit
that referenced
this pull request
Nov 24, 2025
…y_breakdown (#41747) Remove staticmethod decorator from function
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…y_breakdown (huggingface#41747) Remove staticmethod decorator from function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove invalid staticmethod decorator from module-level function
get_device_and_memory_breakdown.This PR removes an incorrect @staticmethod decorator applied to the module-level function
get_device_and_memory_breakdown.The decorator caused a runtime error on Python 3.9, even though it appeared to work fine on newer Python versions.
See
trlstacktrace for Python 3.9: https://github.com/huggingface/trl/actions/runs/18605452485/job/53053774127Root cause
In Python 3.9 and earlier,
@staticmethodproduces a descriptor object that is not directly callable when defined outside a class.Starting with Python 3.10, CPython changed the behavior of
staticmethod: staticmethod objects gained a__call__method that delegates to the wrapped function, making them callable even outside a class context. However, this masked the underlying issue in newer Python versions.Fix
Remove the invalid decorator and leave the function as a normal callable at module scope.
This PR will fix huggingface/trl#4308
CC: @remi-or, who created the original PR: