Conversation
ydshieh
approved these changes
Oct 22, 2025
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
🙏
(I trust you that you run it locally , don't let me down 🙃 please)
Member
Author
|
I did! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
* Fix chat schema tests * make fixup
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
* Fix chat schema tests * make fixup
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* Fix chat schema tests * make fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My bad - the chat schema PR added some tests that were failing after my final commits, and I didn't realize because they weren't running in the CI for the PR.
The main problem was that I dropped support for
"type": "any", which is no longer part of the JSON schema standard, but left it in some tests, which caused errors. This PR changes the code to read a missingtypeannotation as implicitly allowing any type, which is compatible with the standard. It also removes a test for Processor schema save/loading, which was dropped from the PR (but will be added soon!)