Fix validation checks order in benchmark_v2#42280
Merged
remi-or merged 2 commits intohuggingface:mainfrom Nov 19, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
remi-or
approved these changes
Nov 19, 2025
| config["num_tokens_to_generate"] = ntok | ||
| config["gpu_monitoring"] = monitor | ||
| # Remove the old name so it gets re-inferred with the updated values | ||
| config.pop("name", None) |
HichTala
added a commit
to HichTala/transformers
that referenced
this pull request
Dec 8, 2025
This reverts commit ea30d82.
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
fix validation checks order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adapt_configs()preserving old benchmark names (e.g., s128_n128) when parameters are changed via command-line arguments. Remove the name field from the config dict so it gets re-inferred with the updated sequence length and token generation values.@remi-or