Fix: Pass local_files_only from pipeline() to model loading by nandan2003 · Pull Request #42318 · huggingface/transformers

nandan2003 · 2025-11-21T08:09:15Z

Fixes a bug where passing local_files_only=True to pipeline() was ignored, causing models to download from the Hub even when offline mode was explicitly requested.

The Fix:
The local_files_only argument was being extracted from kwargs but was missing from the hub_kwargs dictionary that pipeline() uses to configure downloads. This PR adds the flag to hub_kwargs, ensuring it is correctly propagated to AutoConfig.from_pretrained and load_model.

Reproduction & Verification

I verified this locally by clearing the cache for a specific model (hf-internal-testing/tiny-random-bert) and attempting to load it via pipeline() with local_files_only=True.

Before Fix: The model would download despite the flag.
After Fix: The call correctly raises an OSError (because the model is not locally available), confirming that no connection to the Hub was attempted.

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline, Pull Request section?
Was this discussed/approved via a Github issue or the forum? Yes, issue local_files_only=True in pipeline() does not prevent model downloads in transformers==4.57.1 #42269.
Did you make sure to update the documentation with your changes? (Bug fix, no docs needed).
Did you write any new necessary tests? (Verified manually via reproduction script).

Who can review?

@Rocketknight1 (Pipelines)

nandan2003 · 2025-11-21T19:25:53Z

Branch updated to sync with main.

I verified this locally by clearing the Hugging Face cache and running a test script:

Before: pipeline(..., local_files_only=True) triggered a download.
After: It correctly raises OSError (indicating offline mode is respected).

The CI failure in tests_processors appears unrelated to these changes in pipelines/__init__.py.

Wauplin

Looks good to me, thanks for fixing this!

(might be good to add a test in ./tests/test_pipeline_mixin.py? -let's wait for a review from a transformers's maintainer :) -)

Rocketknight1 · 2025-11-24T15:04:24Z

This PR makes sense to me! One question - can you check in the PEFT path, to see if we need to pass this there too? I'm not sure if the adapter-loading path will respect local_files_only either.

nandan2003 · 2025-11-24T17:46:50Z

This PR makes sense to me! One question - can you check in the PEFT path, to see if we need to pass this there too? I'm not sure if the adapter-loading path will respect local_files_only either.

You're actually right. made some changes and PTAL.

Rocketknight1 · 2025-11-25T15:57:55Z

There's a lot of unrelated style changes here! Can you pip install -e .[quality] to make sure you're using the right versions of the style tools, then make style or make fixup? That should reduce the size of the diff a lot.

Rocketknight1 · 2025-11-26T16:26:58Z

+            from peft.utils.hotswap import (
+                check_hotswap_configs_compatible,
+                hotswap_adapter_from_state_dict,
+            )


Still a lot of unrelated style changes, sorry! Can you check against main and revert the unrelated changes that are just style like this? Most good IDEs have git compare/diff functions that should make it easy enough to do, but doing it manually shouldn't take too long either.

Rocketknight1 · 2025-11-28T17:07:19Z

+    local_files_only = kwargs.get("local_files_only", False)

    hub_kwargs = {
        "revision": revision,
        "token": token,
        "trust_remote_code": trust_remote_code,
        "_commit_hash": commit_hash,
+        "local_files_only": local_files_only,


Hey, I see the review ping but there's still lots of style issues! If you look at the diff, everything in __init__.py except this section is just style changes.

Done. Every other styling change was done by ruff.

…_.py

Rocketknight1 · 2025-12-01T15:04:13Z

@bot /style

github-actions · 2025-12-01T15:04:54Z

Style bot fixed some files and pushed the changes.

Rocketknight1 · 2025-12-01T15:51:31Z

There are some CI issues, not the fault of this PR! Hold on for a day or two and we'll resolve them, then ping me to rerun tests

nandan2003 · 2025-12-17T02:08:07Z

There are some CI issues, not the fault of this PR! Hold on for a day or two and we'll resolve them, then ping me to rerun tests

Hey! Is the CI issues sorted?

HuggingFaceDocBuilderDev · 2025-12-17T14:15:45Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Rocketknight1

Yep, and sorry about that! I'm happy with the changes at this point. Thank you for the PR!

…ace#42318) * Fix: Propagate local_files_only to hub_kwargs and PEFT adapter loading * Fix conflicts and code style * Apply formatting fixes * Apply style fixes * Fix style: Apply minimal changes for local_files_only * Style: Revert formatting and finalize local_files_only fix in __init__.py * Apply style fixes * Trigger tests --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt <Rocketknight1@users.noreply.github.com> Co-authored-by: Matt <rocketknight1@gmail.com>

nandan2003 mentioned this pull request Nov 21, 2025

local_files_only=True in pipeline() does not prevent model downloads in transformers==4.57.1 #42269

Closed

4 tasks

This was referenced Nov 22, 2025

Fix offline cache clean #42308

Closed

Attempt to access socket despite HF_HUB_OFFLINE = 1 if cache warmed outside current process #42197

Closed

Wauplin approved these changes Nov 24, 2025

View reviewed changes

Fix: Propagate local_files_only to hub_kwargs and PEFT adapter loading

385c690

nandan2003 force-pushed the fix-pipeline-local-files branch from e833ed5 to 385c690 Compare November 24, 2025 17:44

nandan2003 added 3 commits November 24, 2025 17:49

Fix conflicts and code style

26391ae

Resolve merge conflicts and fix style

3fb5c23

Apply formatting fixes

dd6a236

Apply style fixes

7630509

nandan2003 force-pushed the fix-pipeline-local-files branch from 4ee4804 to 7630509 Compare November 25, 2025 18:20

Rocketknight1 reviewed Nov 26, 2025

View reviewed changes

Fix style: Apply minimal changes for local_files_only

ec259f7

nandan2003 force-pushed the fix-pipeline-local-files branch from 706a52f to ec259f7 Compare November 27, 2025 18:01

nandan2003 requested a review from Rocketknight1 November 27, 2025 18:03

Rocketknight1 reviewed Nov 28, 2025

View reviewed changes

Style: Revert formatting and finalize local_files_only fix in __init_…

fe9c54f

…_.py

github-actions Bot and others added 4 commits December 1, 2025 15:05

Apply style fixes

ca95ae5

Merge branch 'main' into fix-pipeline-local-files

afb09df

Merge branch 'main' into fix-pipeline-local-files

e6b2f1c

Trigger tests

9d5dc8b

Merge branch 'main' into fix-pipeline-local-files

563ec0e

Rocketknight1 approved these changes Dec 17, 2025

View reviewed changes

Rocketknight1 merged commit 0218f1a into huggingface:main Dec 17, 2025
25 checks passed

Conversation

nandan2003 commented Nov 21, 2025

Reproduction & Verification

Before submitting

Who can review?

Uh oh!

nandan2003 commented Nov 21, 2025

Uh oh!

Wauplin left a comment

Choose a reason for hiding this comment

Uh oh!

Rocketknight1 commented Nov 24, 2025

Uh oh!

nandan2003 commented Nov 24, 2025

Uh oh!

Rocketknight1 commented Nov 25, 2025

Uh oh!

Rocketknight1 Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Rocketknight1 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

nandan2003 Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Rocketknight1 commented Dec 1, 2025

Uh oh!

github-actions Bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rocketknight1 commented Dec 1, 2025

Uh oh!

nandan2003 commented Dec 17, 2025

Uh oh!

HuggingFaceDocBuilderDev commented Dec 17, 2025

Uh oh!

Rocketknight1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Dec 1, 2025 •

edited

Loading

Rocketknight1 left a comment •

edited

Loading