Skip to content

Fix ChineseCLIPModel.get_text_features#42351

Merged
zucchini-nlp merged 1 commit intohuggingface:mainfrom
JiangJQ2000:patch-1
Nov 24, 2025
Merged

Fix ChineseCLIPModel.get_text_features#42351
zucchini-nlp merged 1 commit intohuggingface:mainfrom
JiangJQ2000:patch-1

Conversation

@JiangJQ2000
Copy link
Copy Markdown
Contributor

What does this PR do?

Currently, ChineseCLIPModel.get_text_features will throw the error
TypeError: linear(): argument 'input' (position 1) must be Tensor, not NoneType.
This happens because ChineseCLIPTextModel inside ChineseCLIPModel is instantiated with add_pooling_layer=False, while PR #40555 incorrectly treats its output as BaseModelOutputWithPooling.
Therefore, I reverted the changes related to this part.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: chinese_clip

Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp zucchini-nlp merged commit f7e964e into huggingface:main Nov 24, 2025
17 checks passed
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants