Corrected line 2471 from _config.model_type to _config["model_type"]#42388
Closed
Ankush-Balse wants to merge 1 commit intohuggingface:mainfrom
Closed
Corrected line 2471 from _config.model_type to _config["model_type"]#42388Ankush-Balse wants to merge 1 commit intohuggingface:mainfrom
Ankush-Balse wants to merge 1 commit intohuggingface:mainfrom
Conversation
As per line 2467: _config = json.load(f) In python, since config.json file read is usually a json, it is returned in dictionary format. thus the output of 'json.load(f)' is a <class: dict> object However line 2471 tries to access the key "model_type" in a wrong manner. _config.model_type throws an error since _config is a 'dict' object. Hence corrected to _config["model_type"]
|
This bug breaks loading local fine tuned models. I tried fine tuning gemma3 and it loads fine, but I try and load the fine-tuned version from my local file system and it crashes complaining about |
Collaborator
|
Yes the fix is coming sorry everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per line 2467: _config = json.load(f)
In python, since config.json file read is usually a json, it is returned in dictionary format. thus the output of 'json.load(f)' is a <class: dict> object
However line 2471 tries to access the key "model_type" in a wrong manner. _config.model_type throws an error since _config is a 'dict' object. Hence corrected to _config["model_type"]
What does this PR do?
This pr fixes the incorrect use of _config variable
Fixes # (issue)
As per line 2467:
In python, since config.json file read is usually a json, it is returned in dictionary format. thus the output of 'json.load(f)' is a <class: dict> object
However line 2471 tries to access the key "model_type" in a wrong manner.
Hence _config.model_type will throw an error that
Thus in line 2471, changed _config.model_type to _config["model_type"]