[Trainer] use output.loss when using liger-kernel#42444
Merged
Conversation
Handle loss computation for models using Liger-kernel. fixes #42414
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
9 tasks
SunMarc
reviewed
Nov 27, 2025
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Thanks, left a few ideas to fix this !
Contributor
Author
|
@SunMarc i'll update the accelerate docs based on this change when you approve |
5 tasks
sarathc-cerebras
pushed a commit
to sarathc-cerebras/transformers
that referenced
this pull request
Dec 7, 2025
* use output.loss when using liger Handle loss computation for models using Liger-kernel. fixes huggingface#42414 * Clarify Liger-kernel loss computation in comments * Both standard transformers and Liger models handle shift_labels correctly via **kwargs * removed unused shift_labels reference in loss computation * Remove unused model unwrapping
Member
|
@SunMarc UlyssesSPDataLoaderAdapter took labels out from inputs while inserting shift_labels |
Member
|
Indeed @zhangwj618 ... thanks for spotting this ! I will open a PR for a quick fix |
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* use output.loss when using liger Handle loss computation for models using Liger-kernel. fixes huggingface#42414 * Clarify Liger-kernel loss computation in comments * Both standard transformers and Liger models handle shift_labels correctly via **kwargs * removed unused shift_labels reference in loss computation * Remove unused model unwrapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle loss computation for models using Liger-kernel.
Fixes #42414
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.