Replace VMap that Fails Torch.Export#42721
Closed
YifanShenSZ wants to merge 3 commits intohuggingface:v4.57-releasefrom
Closed
Replace VMap that Fails Torch.Export#42721YifanShenSZ wants to merge 3 commits intohuggingface:v4.57-releasefrom
YifanShenSZ wants to merge 3 commits intohuggingface:v4.57-releasefrom
Conversation
Contributor
|
We have #41852 which should be available in the v5.rc0. I don't think we will backport for v4, as we keep this to patches only (I think). For v4 you can check the |
Author
|
Thx Anton! 🙏 So by |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: llama4 |
Contributor
|
Haha no, I really meant v5 as in major version :D see https://github.com/huggingface/transformers/releases/tag/v5.0.0rc0 |
Author
|
Close as we will get the fix in v5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specific vmap used in causal mask construction would fail torch.export by
The solution is to use a simple causal mask construction
cc @ArthurZucker @Cyrilvallez