Skip to content

Preprocessing fixes and more tests for LFM2-VL#42784

Merged
zucchini-nlp merged 6 commits intohuggingface:mainfrom
Liquid4All:lfm2-vl-fix
Dec 17, 2025
Merged

Preprocessing fixes and more tests for LFM2-VL#42784
zucchini-nlp merged 6 commits intohuggingface:mainfrom
Liquid4All:lfm2-vl-fix

Conversation

@ankke
Copy link
Copy Markdown
Contributor

@ankke ankke commented Dec 10, 2025

Fixes:

  • no image tokens for small images when use_thumbnail set to False
  • repeated text part of the prompt for multi-image and multi-turn input

Adds several missing tests to catch bugs like above earlier.

@Rocketknight1
Copy link
Copy Markdown
Member

cc @zucchini-nlp @molbap @yonigozlan

@zucchini-nlp
Copy link
Copy Markdown
Member

run-slow: lfm2_vl

@github-actions
Copy link
Copy Markdown
Contributor

This comment contains run-slow, running the specified jobs:

models: ["models/lfm2_vl"]
quantizations: []

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super extensive tests, thanks!

@zucchini-nlp
Copy link
Copy Markdown
Member

Tests are failing on main branch so I can't yet merge until they are fixed, let's wait

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: lfm2_vl

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) December 17, 2025 12:29
@zucchini-nlp zucchini-nlp merged commit 558666f into huggingface:main Dec 17, 2025
16 checks passed
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
* fix processing bugs + add more test cases

* add more image processor tests

* refactor expand_text_with_placeholders

* CI fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants