Skip to content

Add an integration test for LASR using pipe and chunked decoding#42823

Merged
eustlb merged 15 commits intohuggingface:mainfrom
kho:pipe_with_chunk_test
Mar 12, 2026
Merged

Add an integration test for LASR using pipe and chunked decoding#42823
eustlb merged 15 commits intohuggingface:mainfrom
kho:pipe_with_chunk_test

Conversation

@kho
Copy link
Copy Markdown
Contributor

@kho kho commented Dec 11, 2025

What does this PR do?

  • Update the goldens for test_model_integration_batched
  • Add an integration test for LASR using pipe and chunked decoding.

This is separated from #42720 per request from @eustlb.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Dec 12, 2025

run-slow: lasr

@github-actions
Copy link
Copy Markdown
Contributor

💔 This comment contains run-slow, but unknown error occurred and the workflow run aborted!

@kho kho force-pushed the pipe_with_chunk_test branch from 957df33 to 2310957 Compare December 12, 2025 16:04
@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Dec 12, 2025

run-slow: lasr

@github-actions
Copy link
Copy Markdown
Contributor

This comment contains run-slow, running the specified jobs:

models: ["models/lasr"]
quantizations: []

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

@kho kho force-pushed the pipe_with_chunk_test branch from 962049f to d352827 Compare December 19, 2025 20:14
@kho kho force-pushed the pipe_with_chunk_test branch from d352827 to 36af114 Compare December 22, 2025 17:59
@kho
Copy link
Copy Markdown
Contributor Author

kho commented Dec 22, 2025

@eustlb This PR would be ready to go once #42920 is in.

@pcuenca pcuenca mentioned this pull request Dec 23, 2025
@eustlb eustlb self-requested a review January 5, 2026 17:24
Copy link
Copy Markdown
Contributor

@eustlb eustlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! running slow tests to ensure values are the correct ones on CI devices.

@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Jan 5, 2026

run-slow: lasr

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2026

💔 This comment contains run-slow, but unknown error occurred and the workflow run aborted!

@eustlb eustlb enabled auto-merge (squash) January 6, 2026 09:13
@eustlb eustlb disabled auto-merge January 6, 2026 09:13
@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Jan 6, 2026

run-slow: lasr

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

💔 This comment contains run-slow, but unknown error occurred and the workflow run aborted!

@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Jan 6, 2026

run-slow: lasr

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

This comment contains run-slow, running the specified jobs:

models: ["models/lasr"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

CI Results

Workflow Run ⚙️

Model CI Report

❌ Failed tests

  • lasr:
    tests/models/lasr/test_modeling_lasr.py::LasrForCTCIntegrationTest::test_model_integration
    tests/models/lasr/test_modeling_lasr.py::LasrForCTCIntegrationTest::test_model_integration_batched
    tests/models/lasr/test_modeling_lasr.py::LasrForCTCIntegrationTest::test_model_integration_pipe_with_chunk

@kho
Copy link
Copy Markdown
Contributor Author

kho commented Jan 6, 2026

The tests are failing due to the model used in integration testing is gated. Let me create a new test model later today.

@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Jan 7, 2026

run-slow: lasr

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2026

This comment contains run-slow, running the specified jobs:

models: ["models/lasr"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2026

CI Results

Workflow Run ⚙️

Model CI Report

❌ Failed tests

  • lasr:
    tests/models/lasr/test_modeling_lasr.py::LasrForCTCIntegrationTest::test_model_integration
    tests/models/lasr/test_modeling_lasr.py::LasrForCTCIntegrationTest::test_model_integration_batched
    tests/models/lasr/test_modeling_lasr.py::LasrForCTCIntegrationTest::test_model_integration_pipe_with_chunk

@classmethod
def setUp(cls):
cls.checkpoint_name = "eustlb/lasr"
cls.checkpoint_name = "hf-internal-testing/lasr-test"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eustlb The test checkpoint is https://huggingface.co/wuketest/lasr_integration_test. Could you help me make a copy to hf-internal-testing/lasr-test?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;)

Copy link
Copy Markdown
Contributor

@eustlb eustlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kho! running slow tests before merging to see whether we need to update value for the runners

@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Feb 9, 2026

run-slow: lasr

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

💔 This comment contains run-slow, but unknown error occurred and the workflow run aborted!

@eustlb
Copy link
Copy Markdown
Contributor

eustlb commented Feb 20, 2026

run-slow: lasr

@eustlb eustlb enabled auto-merge (squash) February 20, 2026 13:38
@github-actions
Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/lasr"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 3579e81d workflow commit (merge commit)
PR 8940358a branch commit (from PR)
main 8151000f base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

kho added 3 commits March 6, 2026 11:44
Because of the out of date tokenizer mapping, AutoTokenizer started returning TokenizersBackend instead LasrTokenizer after huggingface#42894, which caused Google-Health/medasr#12.
auto-merge was automatically disabled March 6, 2026 19:49

Head branch was pushed to by a user without write access

@kho
Copy link
Copy Markdown
Contributor Author

kho commented Mar 6, 2026

run-slow: lasr

@kho
Copy link
Copy Markdown
Contributor Author

kho commented Mar 10, 2026

@eustlb Mind taking another look?

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto, lasr

Copy link
Copy Markdown
Contributor

@eustlb eustlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @kho! I've udpated values for our runners

@eustlb eustlb enabled auto-merge March 12, 2026 09:50
@eustlb eustlb added this pull request to the merge queue Mar 12, 2026
Merged via the queue into huggingface:main with commit dc4016f Mar 12, 2026
28 checks passed
michaelbenayoun pushed a commit to michaelbenayoun/transformers that referenced this pull request Mar 12, 2026
…gingface#42823)

* Add an integration test for LASR using pipe and chunked decoding

* Revise goldens in LasrForCTCIntegrationTest.test_model_integration_batched

* Enable LasrForCTCIntegrationTest

* add require_torch_accelerator

* Use a publicly accessible test model for LASR and update integration test goldens

* Correct the tokenizer mapping for LASR models

Because of the out of date tokenizer mapping, AutoTokenizer started returning TokenizersBackend instead LasrTokenizer after huggingface#42894, which caused Google-Health/medasr#12.

* Remove require_read_token since we now use a publicly assessible test checkpoint

* update values for runners

---------

Co-authored-by: eustlb <94853470+eustlb@users.noreply.github.com>
Co-authored-by: Eustache Le Bihan <eulebihan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants