fix: make mistral base check conditional to fix offline loading#42880
Merged
ArthurZucker merged 2 commits intohuggingface:v4.57-releasefrom Jan 13, 2026
Conversation
This was referenced Dec 15, 2025
vasqu
reviewed
Dec 16, 2025
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Can you add a test? This should fail in general already because the local var _is_local vs is_local
Author
Author
|
And if we add a test we should also merge it to main |
Backport of a small part of huggingface#42528, the model_info call currently breaks offline loading
Author
|
@vasqu Ah I think I misunderstood you, fixed |
Killusions
force-pushed
the
fix/make-mistral-base-check-conditional-to-fix-offline-loading
branch
from
247da3e to
cb94784
Compare
Author
|
@vasqu Also added a test |
Contributor
Author
|
What's the timeline for this? Is there any change you still require before merging this? |
Author
|
Bump @vasqu @ArthurZucker @itazap |
Collaborator
|
Hey! I'll see with @vasqu |
ArthurZucker
added
the
for patch
ArthurZucker
merged commit 33ac6bd
into
huggingface:v4.57-release
10 of 14 checks passed
gdoermann
added a commit
to gdoermann/agents
that referenced
this pull request
Mar 20, 2026
Replace the <=4.57.1 cap with targeted excludes for 4.57.2 and 4.57.3, which had a local_files_only=True regression (huggingface/transformers#42369). The bug was fixed in 4.57.4 (huggingface/transformers#42880), so versions 4.57.4+ and 5.x are safe. The <=4.57.1 cap blocks the entire dependency tree from upgrading to transformers 5.x, which includes a security fix for PVE-2026-85102 (insecure deserialization in Trainer._load_rng_state). Fixes livekit#5173
gdoermann
added a commit
to gdoermann/agents
that referenced
this pull request
Mar 20, 2026
Replace the <=4.57.1 cap with targeted excludes for 4.57.2 and 4.57.3, which had a local_files_only=True regression (huggingface/transformers#42369). The bug was fixed in 4.57.4 (huggingface/transformers#42880), so versions 4.57.4+ and 5.x are safe. The <=4.57.1 cap blocks the entire dependency tree from upgrading to transformers 5.x, which includes a security fix for PVE-2026-85102 (insecure deserialization in Trainer._load_rng_state). Fixes livekit#5173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of a small part of #42528, the model_info call currently breaks offline loading