🚨Fix default interpolation for PVT to match original implementation (Bicubic)#43017
Merged
yonigozlan merged 6 commits intohuggingface:mainfrom Jan 22, 2026
Merged
Conversation
Contributor
Author
|
Ready for review! I have updated the interpolation to BICUBIC to match the original implementation. I also removed the 'Copied from' tag since the implementation now differs from VIT All 18 CI tests are passing. |
34 tasks
Member
yonigozlan
approved these changes
Jan 22, 2026
Member
yonigozlan
left a comment
yonigozlan
left a comment
There was a problem hiding this comment.
Thank you! Happy to merge this
yonigozlan
changed the title
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: pvt |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…Bicubic) (huggingface#43017) * Fix default interpolation for PVT (Fast and Python) to BICUBIC * Polish code and trigger CI restart * Fix docstring to match PILImageResampling.BICUBIC * Remove Copied from tag and finalize BICUBIC fix * Apply make style after removing comment --------- Co-authored-by: yonigozlan <yoni.gozlan@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the default interpolation method for
PvtImageProcessor(both standard and fast versions) fromBILINEARtoBICUBIC.Motivation
The original PVT implementation follows the DeiT training recipe, which relies on Bicubic interpolation.
Additionally, the
timmlibrary (the standard reference for this model) usesinterpolation='bicubic'for all PVT variants.Vision Transformers generally require Bicubic interpolation to preserve high-frequency details during patch embedding.
Checklist
PILImageResampling.BICUBIC.