Fix failing PegasusX, Mvp & LED model integration tests#43245
Merged
Rocketknight1 merged 2 commits intohuggingface:mainfrom Jan 14, 2026
Merged
Fix failing PegasusX, Mvp & LED model integration tests#43245Rocketknight1 merged 2 commits intohuggingface:mainfrom
PegasusX, Mvp & LED model integration tests#43245Rocketknight1 merged 2 commits intohuggingface:mainfrom
Conversation
Member
|
run-slow: led, mvp, pegasus_x |
Rocketknight1
approved these changes
Jan 13, 2026
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
LGTM, will wait for the slow tests before merging!
Contributor
|
This comment contains models: ["models/led", "models/mvp", "models/pegasus_x"] |
Contributor
CI Results✅ No failing test specific to this PR 🎉 ! |
Contributor
Author
Sorry, For got to update the expected strings in LED test. Will update. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sai-Suraj-27
force-pushed
the
fix_batch_encode_plus
branch
from
9c8e62b to
0a04d07
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: led, mvp, pegasus_x |
5 tasks
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…gface#43245) * Fix failing tests due to batch_encode_plus * Updated expected values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes these failing PegasusXModelIntegrationTests, MvpModelIntegrationTests & LEDModelIntegrationTests.
As mentioned in the V5 Migration guide: The
encode_plus&batch_decodemethods are deprecated in favor of__call__&decodemethods respectively. And theclean_up_tokenization_spacesargument is also no longer used as mentioned hereBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@vasqu