fix: access rope_theta correctly in Llama4VisionRotaryEmbedding#43281
Merged
zucchini-nlp merged 2 commits intohuggingface:mainfrom Jan 22, 2026
Merged
fix: access rope_theta correctly in Llama4VisionRotaryEmbedding#43281zucchini-nlp merged 2 commits intohuggingface:mainfrom
rope_theta correctly in Llama4VisionRotaryEmbedding#43281zucchini-nlp merged 2 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Tcc0403 <76503978+Tcc0403@users.noreply.github.com>
Tcc0403
force-pushed
the
llama4-rope-theta
branch
from
0a17ef4 to
d089dc6
Compare
Member
|
run-slow: llama4 |
Contributor
|
This comment contains models: ["models/llama4"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
CI Results✅ No failing test specific to this PR 🎉 ! |
5 tasks
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: llama4 |
vaibhav-research
pushed a commit
to vaibhav-research/transformers
that referenced
this pull request
Jan 22, 2026
…uggingface#43281) Signed-off-by: Tcc0403 <76503978+Tcc0403@users.noreply.github.com> Co-authored-by: Raushan Turganbay <raushan@huggingface.co>
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…uggingface#43281) Signed-off-by: Tcc0403 <76503978+Tcc0403@users.noreply.github.com> Co-authored-by: Raushan Turganbay <raushan@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #43276
rope_thetais no longer accessible viaconfig.rope_thetain v5. It has been moved intoconfig.rope_parametersdictionary.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp