Skip to content

[llama4] update rope with new parameter#43311

Closed
kashif wants to merge 3 commits intomainfrom
kashif-patch-1
Closed

[llama4] update rope with new parameter#43311
kashif wants to merge 3 commits intomainfrom
kashif-patch-1

Conversation

@kashif
Copy link
Copy Markdown
Contributor

@kashif kashif commented Jan 15, 2026

What does this PR do?

use config.rope_parameters["rope_theta"]

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

use `config.rope_parameters["rope_theta"]`
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif requested a review from Cyrilvallez January 16, 2026 14:34
@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: llama4

@github-actions
Copy link
Copy Markdown
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43311&sha=d23c19

@kashif
Copy link
Copy Markdown
Contributor Author

kashif commented Jan 22, 2026

closed as its duplcate of #43402

@kashif kashif closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants