Skip to content

Fix typo in docstring for Sam3TrackerConfig#43368

Merged
Rocketknight1 merged 3 commits intohuggingface:mainfrom
alvarobartt:fix-sam3-tracker-config-typo
Jan 22, 2026
Merged

Fix typo in docstring for Sam3TrackerConfig#43368
Rocketknight1 merged 3 commits intohuggingface:mainfrom
alvarobartt:fix-sam3-tracker-config-typo

Conversation

@alvarobartt
Copy link
Copy Markdown
Member

What does this PR do?

This PR fixes a typo in Sam3Tracker docstring in Sam3Trackerconfig, which is fixed as Sam3TrackerConfig (casing in the "c").

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yonigozlan

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thank you for the fix!

@Rocketknight1
Copy link
Copy Markdown
Member

@alvarobartt can you make the update in the modular file for sam3 and then run make fix-repo to sort out the consistency checks?

@alvarobartt
Copy link
Copy Markdown
Member Author

@alvarobartt can you make the update in the modular file for sam3 and then run make fix-repo to sort out the consistency checks?

Hey @Rocketknight1, so apparently the typo is not in the modular file, but rather also on the Sam2Config inherited class, which seems not generated from the modular file for SAM2, right? Maybe I'm missing something not sure, I've updated the typo in the Sam2Config docstring too though!

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: edgetam, sam2, sam3_tracker

@Rocketknight1
Copy link
Copy Markdown
Member

Wow, yes, this was a capitalization issue that propagated across two totally different class names via modular updates. I've never seen that before, but good job figuring it out!

@Rocketknight1 Rocketknight1 merged commit 5c77298 into huggingface:main Jan 22, 2026
19 checks passed
vaibhav-research pushed a commit to vaibhav-research/transformers that referenced this pull request Jan 22, 2026
* Fix typo in docstring for `Sam3TrackerConfig`

* Fix `Sam2Config` typo in `configuration_sam2.py`

* Run `make fix-repo`
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
* Fix typo in docstring for `Sam3TrackerConfig`

* Fix `Sam2Config` typo in `configuration_sam2.py`

* Run `make fix-repo`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants