fix(models) : string mutation bug in from_proteinnet_string#43380
Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom Jan 21, 2026
Merged
Conversation
Rocketknight1
approved these changes
Jan 21, 2026
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Yup, makes sense! I doubt this code path was ever taken, but the fix is clean and obviously correct so we might as well include it.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vaibhav-research
pushed a commit
to vaibhav-research/transformers
that referenced
this pull request
Jan 21, 2026
…ace#43380) fix(models): string mutation bug in from_proteinnet_string
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…ace#43380) fix(models): string mutation bug in from_proteinnet_string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what does this PR do?
fixes a
TypeErrorinopenfold_utils/protein.pywherefrom_proteinnet_stringattempts to mutate an immutable string in-place.the original code tried to assign seq[i] = "X" to handle unknown residues, which crashes. this pr replaces that logic with a list comprehension to safely sanitize the sequence, resolving the existing
FIXME.before submitting
who can review?
@ArthurZucker