Fix always issuing generation deprecation warning#43389
Merged
ydshieh merged 1 commit intohuggingface:mainfrom Jan 22, 2026
Merged
Fix always issuing generation deprecation warning#43389ydshieh merged 1 commit intohuggingface:mainfrom
ydshieh merged 1 commit intohuggingface:mainfrom
Conversation
githubnemo
force-pushed
the
issue/deprecation-always-issued
branch
from
c926f83 to
aeb8ffe
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
approved these changes
Jan 22, 2026
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks, one tiny question and then feel free to merge :)
Comment on lines
+2716
to
+2719
| try: | ||
| # Providing generation_config and kwargs is deprecated, so we expect a warning here. | ||
| # | ||
| # We're using logging_once, make sure that we emit this warning in any case by clearing the |
Member
There was a problem hiding this comment.
nit: what is the purpose of try, and can we let it fail explicitly to know that this test has issues instead of silent skip
Contributor
Author
There was a problem hiding this comment.
try without except doesn't catch the exceptions, it executes the code in try and then invokes finally to clean up - that's the only purpose of this construct is to remove the logging handler after the test is done in any case (exception thrown because of assertion failure or not)
Commit 38e5987 from PR huggingface#43194 introduced a minor bug that causes the issuing of a deprecation warning regardless of the user using the deprecated interface. For example: ``` model.generate(**input_ids, do_sample=False) ``` would issue a deprecation warning not to pass `GenerationConfig` as well as generation kwargs even though we're not passing a `GenerationConfig`. Along the fix this also introduces a unit test to check both the intended and the bug behavior.
githubnemo
force-pushed
the
issue/deprecation-always-issued
branch
from
aeb8ffe to
e7cd078
Compare
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43389&sha=e7cd07 |
vaibhav-research
pushed a commit
to vaibhav-research/transformers
that referenced
this pull request
Jan 22, 2026
Commit 38e5987 from PR huggingface#43194 introduced a minor bug that causes the issuing of a deprecation warning regardless of the user using the deprecated interface. For example: ``` model.generate(**input_ids, do_sample=False) ``` would issue a deprecation warning not to pass `GenerationConfig` as well as generation kwargs even though we're not passing a `GenerationConfig`. Along the fix this also introduces a unit test to check both the intended and the bug behavior. Co-authored-by: nemo <git@ningu.net>
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
Commit 38e5987 from PR huggingface#43194 introduced a minor bug that causes the issuing of a deprecation warning regardless of the user using the deprecated interface. For example: ``` model.generate(**input_ids, do_sample=False) ``` would issue a deprecation warning not to pass `GenerationConfig` as well as generation kwargs even though we're not passing a `GenerationConfig`. Along the fix this also introduces a unit test to check both the intended and the bug behavior. Co-authored-by: nemo <git@ningu.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Note: already discussed with @zucchini-nlp internally
Commit 38e5987 from PR #43194 introduced a minor bug that causes the issuing of a deprecation warning regardless of the user using the deprecated interface.
For example:
would issue a deprecation warning not to pass
GenerationConfigas well as generation kwargs even though we're not passing aGenerationConfig.Along the fix this also introduces a unit test to check both the intended and the bug behavior.