Fix failing recurrent_gemma tests#43405
Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom Jan 22, 2026
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: recurrent_gemma |
Rocketknight1
approved these changes
Jan 22, 2026
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yes, the position_ids were ending up as the unsqueeze_dim because the kwarg was removed. Thank you for the fix!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vaibhav-research
pushed a commit
to vaibhav-research/transformers
that referenced
this pull request
Jan 22, 2026
Fix failing recurrent_gemma tests
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
Fix failing recurrent_gemma tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes these failing recurrent_gemma tests.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1 @vasqu, @Cyrilvallez (#43255)