Skip to content

Chore(tests): Fix values for test_inference_for_video_classification#43406

Merged
tarekziade merged 2 commits intohuggingface:mainfrom
tarekziade:tarekziade-fix-test_inference_for_video_classification
Jan 23, 2026
Merged

Chore(tests): Fix values for test_inference_for_video_classification#43406
tarekziade merged 2 commits intohuggingface:mainfrom
tarekziade:tarekziade-fix-test_inference_for_video_classification

Conversation

@tarekziade
Copy link
Copy Markdown
Collaborator

@tarekziade tarekziade commented Jan 22, 2026

What does this PR do?

Fixes test_inference_for_video_classification failure in a multi-gpu environement.

See https://github.com/huggingface/transformers/actions/runs/21157884595/job/60846617284

The patch tweaks the values with reality

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@tarekziade tarekziade requested a review from ydshieh January 22, 2026 10:33
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tarekziade tarekziade changed the title fix values for test_inference_for_video_classification Chore(tests): Fix values for test_inference_for_video_classification Jan 22, 2026
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🔥

Congrats for the first PR!

Comment thread tests/models/vivit/test_modeling_vivit.py Outdated
@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: vivit

@tarekziade
Copy link
Copy Markdown
Collaborator Author

@ydshieh do we want to run vit/vivit on the gpu workers before merging? (I tried manually the fix in ssh)

@tarekziade tarekziade merged commit f60129d into huggingface:main Jan 23, 2026
19 checks passed
@tarekziade tarekziade deleted the tarekziade-fix-test_inference_for_video_classification branch January 23, 2026 09:23
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants