Fix in-place modification of inputs_embeds in Kosmos-2.5 forward#43418
Merged
zucchini-nlp merged 2 commits intohuggingface:mainfrom Jan 23, 2026
Merged
Fix in-place modification of inputs_embeds in Kosmos-2.5 forward#43418zucchini-nlp merged 2 commits intohuggingface:mainfrom
zucchini-nlp merged 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: kosmos2_5 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…gingface#43418) * Fix in-place modification of inputs_embeds in Kosmos-2.5 forward * Removed trailing space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a PyTorch autograd error when fine-tuning
Kosmos2_5ForConditionalGenerationwith PEFT (LoRA).The model forward pass performed an in-place assignment on
inputs_embeds, which can be a leaf tensor withrequires_grad=Trueduring training. This caused the following runtime error:RuntimeError: a leaf Variable that requires grad is being used in an in-place operation
This PR avoids the in-place modification by cloning the tensor before assignment, allowing training to proceed correctly while preserving existing behavior.
I have verified the fix using the reproduction script I provided in the issue; the RuntimeError is resolved and training proceeds as expected.
Fixes #43416
cc @zucchini-nlp