Patch set_attn_implementation for Windows#43433
Merged
ArthurZucker merged 3 commits intohuggingface:mainfrom Jan 23, 2026
Merged
Patch set_attn_implementation for Windows#43433ArthurZucker merged 3 commits intohuggingface:mainfrom
ArthurZucker merged 3 commits intohuggingface:mainfrom
Conversation
idem with set_experts_implementation
5 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
Fixed, turns out my
|
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43433&sha=f9f404 |
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* Patch set_attn_implementation for Windows idem with set_experts_implementation * Extend the fix to _can_set_experts_implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It patches the following on Windows devices:
With this PR in place, it simply returns:
Follow-up from #42564 (comment)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@vasqu
It would be very nice to include this in the v5. This caused test failures for my work on #42564 for ChineseCLIP and AyaVision, likely as those modeling files have characters that the default Windows
cp1252encoding doesn't recognize.