[Bugfix] Extract pad_token_id from text config for Llama-4#43497
Closed
eldarkurtic wants to merge 1 commit intohuggingface:mainfrom
Closed
[Bugfix] Extract pad_token_id from text config for Llama-4#43497eldarkurtic wants to merge 1 commit intohuggingface:mainfrom
eldarkurtic wants to merge 1 commit intohuggingface:mainfrom
Conversation
eldarkurtic
changed the title
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: llama4 |
Member
|
cc @zucchini-nlp I think this is the same bug as Qwen3 |
Member
|
Was this now resolved in #43539, @Rocketknight1? If so, we can close.
|
Member
|
Yes, I think we can close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Loading Llama-4 model with
Llama4ForConditionalGenerationfails becauseself.config.pad_token_iddoesn't exist. For Llama-4 models,pad_token_idis insidetext_confignot the general config.