Skip to content

Fix typo in quantization_operations in PEFT integrations#43821

Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom
redpanda1995:typo_fix
Feb 11, 2026
Merged

Fix typo in quantization_operations in PEFT integrations#43821
ArthurZucker merged 1 commit intohuggingface:mainfrom
redpanda1995:typo_fix

Conversation

@redpanda1995
Copy link
Copy Markdown

@redpanda1995 redpanda1995 commented Feb 7, 2026

What does this PR do?

Fixes [# (issue)]

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Copy Markdown
Member

cc @sayakpaul - will this fix break the call?

@sayakpaul
Copy link
Copy Markdown
Member

I think @ArthurZucker is more equipped to answer that.

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty cc @Cyrilvallez from your #43585 👁️ 👁️

@ArthurZucker ArthurZucker merged commit 42dc276 into huggingface:main Feb 11, 2026
23 checks passed
@ishaan-shivhare
Copy link
Copy Markdown

Hi sorry, following up on this since I had raised the original issue
Isn't it still incorrect:

quantization_operation: ConversionOps | None = None

shouldn't it be quantization_operation singular?

@Cyrilvallez
Copy link
Copy Markdown
Member

Damn, thanks a lot @ishaan-shivhare! You're really correct 😅 Just opened #44053 to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants