Fix AttributeError for remote models with trust_remote_code=True#43951
Closed
lordaarush wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix AttributeError for remote models with trust_remote_code=True#43951lordaarush wants to merge 1 commit intohuggingface:mainfrom
lordaarush wants to merge 1 commit intohuggingface:mainfrom
Conversation
Fixes huggingface#43883 After huggingface#42270, all_tied_weights_keys is initialized in post_init(), but remote models loaded with trust_remote_code=True don't always call post_init() properly, causing AttributeError when loading models like Molmo. This fix adds defensive checks in two methods: - _adjust_tied_keys_with_tied_pointers(): Initialize empty dict if missing, then detect tied weights via data pointers - mark_tied_weights_as_initialized(): Return early if attribute missing This allows remote models to load successfully while maintaining tied weight detection.
Member
|
See my answer here #43883 (comment)! In the meantime, I'm closing the PR! Let me know if you need anything else 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #43883
After #42270,
all_tied_weights_keysis initialized inpost_init(), but remote models loaded withtrust_remote_code=Truedon't always callpost_init()properly, causingAttributeErrorwhen loading models like Molmo.This fix adds defensive checks in two methods:
_adjust_tied_keys_with_tied_pointers(): Initialize empty dict if missing, then detect tied weights via data pointersmark_tied_weights_as_initialized(): Return early if attribute missingThis allows remote models to load successfully while maintaining tied weight detection.
Before submitting
Who can review?
@Rocketknight1 @Cyrilvallez