Skip to content

refactor _inner_training_loop to smaller methods #44041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winglian merged 21 commits into from
Feb 23, 2026
Merged

refactor _inner_training_loop to smaller methods #44041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a50e35e
refactor _inner_training_loop to smaller methods
winglian Feb 13, 2026
4bbbac1
address PR comments and remove unused args
winglian Feb 17, 2026
48391e9
move _train_batch_size
SunMarc Feb 18, 2026
cda1b84
big update
SunMarc Feb 19, 2026
f52ffbf
Merge remote-tracking branch 'origin/main' into refactor-inner-traini…
SunMarc Feb 19, 2026
c9f3610
move DummyScheduler
SunMarc Feb 19, 2026
f4cad42
style
SunMarc Feb 19, 2026
46e2041
make it private
SunMarc Feb 19, 2026
da07a71
switch to kwargs_handlers
SunMarc Feb 19, 2026
c6bee6a
style
SunMarc Feb 19, 2026
daec115
fix resuming
SunMarc Feb 19, 2026
a434736
style
SunMarc Feb 19, 2026
fa55154
revert loading after
SunMarc Feb 19, 2026
c18c167
way better now
SunMarc Feb 19, 2026
2ced96a
move method
SunMarc Feb 19, 2026
7feecab
small mistake
SunMarc Feb 19, 2026
b37736d
update
SunMarc Feb 19, 2026
a697854
remove tp_size
SunMarc Feb 20, 2026
cc24432
account for grpo
SunMarc Feb 20, 2026
2e97639
final touch
SunMarc Feb 23, 2026
23a6e8b
Merge branch 'main' into refactor-inner-training-loop-reorder-only
SunMarc Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/transformers/testing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,12 +1468,8 @@ def get_steps_per_epoch(trainer: Trainer) -> int:
training_args = trainer.args
train_dataloader = trainer.get_train_dataloader()

initial_training_values = trainer.set_initial_training_values(
args=training_args,
dataloader=train_dataloader,
total_train_batch_size=training_args.per_device_train_batch_size,
)
steps_per_epoch = initial_training_values[1]
initial_training_values = trainer.set_initial_training_values(args=training_args, dataloader=train_dataloader)
steps_per_epoch = initial_training_values[5]
Comment thread
qgallouedec marked this conversation as resolved.

return steps_per_epoch

Expand Down
Loading