Skip to content

Strict export cleanup#44293

Merged
IlyasMoutawwakil merged 8 commits intomainfrom
strict-export-cleanup
Mar 2, 2026
Merged

Strict export cleanup#44293
IlyasMoutawwakil merged 8 commits intomainfrom
strict-export-cleanup

Conversation

@IlyasMoutawwakil
Copy link
Copy Markdown
Member

@IlyasMoutawwakil IlyasMoutawwakil commented Feb 26, 2026

What does this PR do?

#44266 (comment)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Comment thread src/transformers/utils/import_utils.py
@IlyasMoutawwakil IlyasMoutawwakil marked this pull request as ready for review February 27, 2026 13:28
Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit on the skip, would it be possible to drop labels to avoid the loss calculation instead?

Comment thread tests/test_modeling_common.py Outdated
Comment thread tests/models/albert/test_modeling_albert.py
@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Feb 27, 2026

You need to sync with main for the processor tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: albert, bert, deformable_detr, depth_anything, distilbert, dpt, mask2former, mobilebert, modernbert, prompt_depth_anything, roberta, vits

@IlyasMoutawwakil IlyasMoutawwakil merged commit dd5f1a1 into main Mar 2, 2026
26 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the strict-export-cleanup branch March 2, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants