chore(typing): Add type checking to `src/transformers/quantizers` by tarekziade · Pull Request #44412 · huggingface/transformers

tarekziade · 2026-03-03T14:53:31Z

What does this PR do?

Extends type checking to src/transformers/quantizers

tarekziade · 2026-03-03T14:57:57Z

Based on the #44233 branch

tarekziade · 2026-03-05T18:34:54Z



+MIN_GPTQ_VERSION = "1.4.3"
+MIN_OPTIMUM_VERSION = "1.24.0"


using cleaner constants, also not sure why we had 1.24.0 and 1.23.99 checks so I cleaned it up after checking optimum releases that exist

vasqu

Just some smaller stuff, noticed one inconsistency

cc @SunMarc if you also have time to take a quick look

HuggingFaceDocBuilderDev · 2026-03-09T11:24:59Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

vasqu

LGTM, thanks for iterating. Would be nice if you could take a look at the aqlm test or at least check if it was indeed broken before

tarekziade · 2026-03-10T10:36:15Z

run-slow: fbgemm_fp8, finegrained_fp8, gptq, higgs, hqq, metal, mxfp4, sinq

github-actions · 2026-03-10T10:37:33Z

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/fbgemm_fp8", "quantization/finegrained_fp8", "quantization/gptq", "quantization/higgs", "quantization/hqq", "quantization/metal", "quantization/mxfp4", "quantization/sinq"]

github-actions · 2026-03-10T10:58:37Z

CI Results

Workflow Run ⚙️

Commit Info

Context	Commit	Description
RUN	167c0a3a	workflow commit (merge commit)
PR	7e6c53f4	branch commit (from PR)
main	5a098a1e	base commit (on `main`)

⚠️ Quantization CI failed to report results

The test failure analysis could not be completed. Please check the workflow run for details.

tarekziade · 2026-03-10T11:07:43Z

run-slow: aqlm

tarekziade · 2026-03-10T14:16:38Z

run-slow: fbgemm_fp8, finegrained_fp8, gptq, higgs, hqq, metal, mxfp4, sinq

github-actions · 2026-03-10T14:18:06Z

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/fbgemm_fp8", "quantization/finegrained_fp8", "quantization/gptq", "quantization/higgs", "quantization/hqq", "quantization/metal", "quantization/mxfp4", "quantization/sinq"]

github-actions · 2026-03-10T15:09:09Z

CI Results

Workflow Run ⚙️

Commit Info

Context	Commit	Description
RUN	e9ad717f	workflow commit (merge commit)
PR	dacbfde5	branch commit (from PR)
main	1cbb9c2e	base commit (on `main`)

⚠️ Quantization CI failed to report results

The test failure analysis could not be completed. Please check the workflow run for details.

tarekziade · 2026-03-10T15:30:09Z

run-slow: aqlm_integration

github-actions · 2026-03-10T15:31:35Z

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/aqlm_integration"]

tarekziade · 2026-03-10T15:38:51Z

run-slow: fbgemm_fp8, finegrained_fp8, gptq, higgs, hqq, metal, mxfp4, sinq

github-actions · 2026-03-10T15:39:20Z

CI Results

Workflow Run ⚙️

Commit Info

Context	Commit	Description
RUN	e9ad717f	workflow commit (merge commit)
PR	dacbfde5	branch commit (from PR)
main	1cbb9c2e	base commit (on `main`)

⚠️ No test being reported (jobs are skipped or cancelled)!

github-actions · 2026-03-10T15:40:41Z

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/fbgemm_fp8", "quantization/finegrained_fp8", "quantization/gptq", "quantization/higgs", "quantization/hqq", "quantization/metal", "quantization/mxfp4", "quantization/sinq"]

Co-authored-by: vasqu

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>

tarekziade · 2026-03-11T07:33:59Z

run-slow: fbgemm_fp8, finegrained_fp8, gptq, higgs, hqq, metal, mxfp4, sinq

github-actions · 2026-03-11T07:34:31Z

[For maintainers] Suggested jobs to run (before merge)

run-slow: fbgemm_fp8, finegrained_fp8, gptq, higgs, hqq, metal, mxfp4, sinq

tarekziade · 2026-03-11T07:34:37Z

run-slow: fbgemm_fp8, finegrained_fp8, gptq, higgs, hqq, metal, mxfp4, sinq

github-actions · 2026-03-11T07:34:47Z

Workflow Run ⚙️💔 This comment contains run-slow, but unknown error occurred and the workflow run aborted!

github-actions · 2026-03-11T07:36:07Z

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: []
quantizations: ["quantization/fbgemm_fp8", "quantization/finegrained_fp8", "quantization/gptq", "quantization/higgs", "quantization/hqq", "quantization/metal", "quantization/mxfp4", "quantization/sinq"]

github-actions · 2026-03-11T07:51:23Z

CI Results

Workflow Run ⚙️

Commit Info

Context	Commit	Description
RUN	2cc9a71c	workflow commit (merge commit)
PR	331b3687	branch commit (from PR)
main	42ff4f32	base commit (on `main`)

✅ No failing test specific to this PR 🎉 👏 !

tarekziade force-pushed the tarekziade-typing-quantizers branch from 7f3d268 to 8049911 Compare March 3, 2026 14:55

tarekziade changed the title ~~chore(typing): Add type checking to src/transformers/generation~~ chore(typing): Add type checking to src/transformers/quantizers Mar 3, 2026

tarekziade self-assigned this Mar 3, 2026

tarekziade force-pushed the tarekziade-typing-quantizers branch 2 times, most recently from 87ac38b to ea21220 Compare March 5, 2026 17:45

tarekziade commented Mar 5, 2026

View reviewed changes

tarekziade requested a review from vasqu March 5, 2026 18:39

vasqu reviewed Mar 6, 2026

View reviewed changes

tarekziade force-pushed the tarekziade-typing-quantizers branch 2 times, most recently from 5714a08 to b202c77 Compare March 6, 2026 15:35

tarekziade requested a review from vasqu March 6, 2026 15:43

tarekziade force-pushed the tarekziade-typing-quantizers branch from dbe048c to ee5781d Compare March 9, 2026 11:15

vasqu approved these changes Mar 9, 2026

View reviewed changes

Comment thread src/transformers/quantizers/quantizer_aqlm.py

Comment thread src/transformers/quantizers/quantizer_bnb_4bit.py Outdated

tarekziade force-pushed the tarekziade-typing-quantizers branch from 9cbadfa to 7e6c53f Compare March 10, 2026 10:20

tarekziade mentioned this pull request Mar 10, 2026

chore(typing): extend typing to src/transformers/cli #44566

Closed

vasqu reviewed Mar 10, 2026

View reviewed changes

Comment thread src/transformers/quantizers/quantizer_bnb_4bit.py Outdated

tarekziade and others added 16 commits March 11, 2026 08:27

lets just use setattr

3288c13

tweaked one more optimum version

f75067c

setattr again

c8f41de

more setattr/getattr patyterns

d40101d

more cleanups

9d5dd5e

fmt

756794f

cleanups from rebase abd ty 0.20.0

7e3cb42

fix ignores

d044b38

const for torchao version

1c9bd9f

simplify call

d7e87d5

Co-authored-by: vasqu

use is_torch_greater_or_equal

a0213d8

use type guard

c4dd7b4

remove the getattr() pattenr

f5f9cc2

reworked the approach

a0b2785

Update src/transformers/quantizers/quantizer_sinq.py

30c3100

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>

Update src/transformers/quantizers/quantizer_quanto.py

d29ec94

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>

tarekziade force-pushed the tarekziade-typing-quantizers branch from ce0ca96 to d29ec94 Compare March 11, 2026 07:33

class is there we can use it

331b368

tarekziade added this pull request to the merge queue Mar 11, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 11, 2026

tarekziade added this pull request to the merge queue Mar 11, 2026

Merged via the queue into main with commit 8464284 Mar 11, 2026
30 checks passed

tarekziade deleted the tarekziade-typing-quantizers branch March 11, 2026 08:32



		MIN_GPTQ_VERSION = "1.4.3"
		MIN_OPTIMUM_VERSION = "1.24.0"

Conversation

tarekziade commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

tarekziade commented Mar 3, 2026

Uh oh!

tarekziade Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

vasqu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HuggingFaceDocBuilderDev commented Mar 9, 2026

Uh oh!

vasqu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tarekziade commented Mar 10, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

CI Results

Commit Info

Uh oh!

tarekziade commented Mar 10, 2026

Uh oh!

Uh oh!

tarekziade commented Mar 10, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

CI Results

Commit Info

Uh oh!

tarekziade commented Mar 10, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

tarekziade commented Mar 10, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

CI Results

Commit Info

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

tarekziade commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

tarekziade commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026

CI Results

Commit Info

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

tarekziade commented Mar 3, 2026 •

edited

Loading