[tie weights] 🚨 If both weights are present with same weights, still tie them#44497
Merged
Cyrilvallez merged 5 commits intomainfrom Mar 9, 2026
Merged
[tie weights] 🚨 If both weights are present with same weights, still tie them#44497Cyrilvallez merged 5 commits intomainfrom
Cyrilvallez merged 5 commits intomainfrom
Conversation
vasqu
approved these changes
Mar 9, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
I think we all agree to this PR after the internal discussions but let's add a 🚨 just in case. It is slightly breaking, even if it is for the better
Cyrilvallez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. Fixes #44466 and avoid issues with torch
.bincheckpoints which always contain both keys!