[FA] Refactor FA CB kwargs#44553
Draft
vasqu wants to merge 8 commits intohuggingface:mainfrom
Draft
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bark, diffllama, falcon, gpt_neo, gptj, kyutai_speech_to_text, mimi, moshi, nemotron |
vasqu
changed the title
FA] Move CB support to main modelingFA] Refactor FA CB kwarg
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44553&sha=a63e4e |
remi-or
reviewed
Mar 17, 2026
| inputs=input_ids, generation_config=gen_config, continuous_batching_config=continuous_batching_config | ||
| ) | ||
| self.assertTrue(mock_get_block_table_key.called, "get_block_table_key method was not called.") | ||
| outputs_kvcache = model.generate_batch( |
Collaborator
There was a problem hiding this comment.
Could we keep the patch to check the function is indeed called? But the patch would be on _prepare_kvcache_fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title, wip and really unsure if we really want this