Allow mm_token_type be non-padded lists #44563
Merged
zucchini-nlp merged 13 commits intohuggingface:mainfrom Mar 25, 2026
Merged
Allow mm_token_type be non-padded lists #44563zucchini-nlp merged 13 commits intohuggingface:mainfrom
mm_token_type be non-padded lists #44563zucchini-nlp merged 13 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yonigozlan
approved these changes
Mar 23, 2026
Member
yonigozlan
left a comment
yonigozlan
left a comment
There was a problem hiding this comment.
Just some small comments mostly on llava, but overall LGTM!
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: aria, aya_vision, chameleon, cohere2_vision, colmodernvbert, emu3, florence2, fuyu, gemma3, glm46v, glm4v, glm_image, idefics3, internvl, lighton_ocr, llava |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
Mar 27, 2026
* squash commit * several forks mixed up, revert * oops * glms * commit lost when rebasing, revert * typing hints * more failures * fix repo * comments and revert unrelated * fix style * fix repo
NielsRogge
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Mar 30, 2026
* squash commit * several forks mixed up, revert * oops * glms * commit lost when rebasing, revert * typing hints * more failures * fix repo * comments and revert unrelated * fix style * fix repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Split out
mm_token_type_idcreation to a separate utility and just call it in VLMs. Also make sure thatmm_token_type_idcan be created even whenpadding=Falseand the inputs are of different length. As long as thereturn_typeis not an array, it should workFixes #44545 and fixes #44514