Fix annotations reader for python 3.14 in PreTrainedModel#44672
Merged
Rocketknight1 merged 1 commit intohuggingface:mainfrom Mar 19, 2026
Merged
Fix annotations reader for python 3.14 in PreTrainedModel#44672Rocketknight1 merged 1 commit intohuggingface:mainfrom
PreTrainedModel#44672Rocketknight1 merged 1 commit intohuggingface:mainfrom
Conversation
Member
|
This LGTM, and is a much cleaner fix! It will not work on Python 3.9 or earlier, but these are now EOL and no longer supported, so I think it's okay. |
Rocketknight1
approved these changes
Mar 18, 2026
Contributor
Author
|
Thank you @Rocketknight1! ❤️ I do wonder if we're going to backport this to another v4 release 😳 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
@neo unlikely unfortunately, backports to |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There's an issue in Python 3.14 that
__annotations__is not available anymore because of an implementation change (ref), and it breaks the config retrieving logic.This fix would use the recommended reader to properly get the annotations.
This is similar to and trying to fix the same issue as #44165, but it should hopefully look and feel less risky.
(I hope this can also be patched back to v4)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Rocketknight1 @ArthurZucker @Cyrilvallez @vasqu