Skip to content

feat: added cache to the model linter#44790

Merged
tarekziade merged 3 commits intomainfrom
tarekziade-lint-cache
Mar 20, 2026
Merged

feat: added cache to the model linter#44790
tarekziade merged 3 commits intomainfrom
tarekziade-lint-cache

Conversation

@tarekziade
Copy link
Copy Markdown
Collaborator

@tarekziade tarekziade commented Mar 17, 2026

What does this PR do?

This patch

  • adds a simple cache to the model linter so we skip files that did not change and were valid
  • reworks Makefile targets

@tarekziade tarekziade requested a review from Cyrilvallez March 17, 2026 08:54
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@huggingface huggingface deleted a comment from CYzhr Mar 17, 2026
@tarekziade tarekziade self-assigned this Mar 18, 2026
@tarekziade tarekziade force-pushed the tarekziade-lint-cache branch from 4b3b255 to 6c8c308 Compare March 19, 2026 15:00
@tarekziade tarekziade requested a review from vasqu March 19, 2026 15:01
Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just see my comment re the make check repo

Let's see if @Cyrilvallez can be convinced to split this

Comment thread Makefile Outdated
@tarekziade tarekziade force-pushed the tarekziade-lint-cache branch from 6c8c308 to aad773c Compare March 20, 2026 07:48
Copy link
Copy Markdown
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@tarekziade tarekziade added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit 2cd52c2 Mar 20, 2026
18 checks passed
@tarekziade tarekziade deleted the tarekziade-lint-cache branch March 20, 2026 09:43
@kovalevich77755-blip
Copy link
Copy Markdown

What does this PR do?

This patch

  • adds a simple cache to the model linter so we skip files that did not change and were valid
  • reworks targetsMakefile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants