fix(janus): handle None values in image generation mode#44814
Closed
BillionClaw wants to merge 1 commit intohuggingface:mainfrom
Closed
fix(janus): handle None values in image generation mode#44814BillionClaw wants to merge 1 commit intohuggingface:mainfrom
BillionClaw wants to merge 1 commit intohuggingface:mainfrom
Conversation
Fixes huggingface#44792 - Add null check for generation_config.num_return_sequences (default to 1) - Add null check for generation_config.max_length (default to 0)
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: janus |
Contributor
|
Hi @BillionClaw , Just curious why you submit this PR, rather than use #44793 |
Member
|
As mentioned in the other PR
I'll close this as duplicate, it's the same GH user so I assume you can update #44793 as per review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44792
This PR fixes the failing test
test_model_generate_imagesfor the Janus model.Problem
When generating images with the Janus model,
generation_config.num_return_sequencesandgeneration_config.max_lengthcan beNone, causing the following errors:TypeErrorwhennum_return_sequencesisNoneand used asexpand_sizeTypeErrorwhenmax_lengthisNoneand used inmax()comparisonFix
generation_config.num_return_sequenceswith default value of 1generation_config.max_lengthwith default value of 0These changes ensure that the image generation mode works correctly when these configuration values are not explicitly set.