refactor: unify QA calls#44879
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| parallelism: 1 | ||
| steps: | ||
| - checkout | ||
| - run: apt-get update && apt-get install -y make |
There was a problem hiding this comment.
it's ok, but later we (me) can just add this to the docker file too
There was a problem hiding this comment.
ah, you already done that.
So I guess you just wanted to check the work in this PR works as expected (without pushing the new images).
In any case, keep this part or remove it before merge, both works for me
There was a problem hiding this comment.
yeah, I can remove from the yaml. I wondered: does it need to be pushed separately before we merge this PR?
There was a problem hiding this comment.
trust you on the details of this :-)
tarekziade
force-pushed
the
tarekziade-unified-calls
branch
from
f160b81 to
76a45a4
Compare
tarekziade
force-pushed
the
tarekziade-unified-calls
branch
from
6664905 to
9657c64
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44879&sha=c3ba92 |
* unify calls * give me make! * added tomli to quality extra * keep teh exact same behavior * remove circleCI from agent file * unified UI * better UX * fix typing target * dev-ci * dev-ci * hardcoded :dev * removed dev blocks and python version marker * make fix-repo
* unify calls * give me make! * added tomli to quality extra * keep teh exact same behavior * remove circleCI from agent file * unified UI * better UX * fix typing target * dev-ci * dev-ci * hardcoded :dev * removed dev blocks and python version marker * make fix-repo
3 participants
What does this PR do?
tomlisomakecommands can read thetomlfile when neededcheckersPython module that wraps and orchestrates allcheckscalls