Fix CPU 16 bytes alignment issue using equivalent fallback#44970
Merged
IlyasMoutawwakil merged 11 commits intomainfrom Mar 25, 2026
Merged
Fix CPU 16 bytes alignment issue using equivalent fallback#44970IlyasMoutawwakil merged 11 commits intomainfrom
IlyasMoutawwakil merged 11 commits intomainfrom
Conversation
vasqu
approved these changes
Mar 24, 2026
| weight.device.type == "cpu" and is_torch_less_or_equal("2.10") and (weight.data_ptr() % 16 != 0) | ||
| ): | ||
| # torch.grouped_mm is not supported in torch.compile with dtypes other than bfloat16 | ||
| # before PyTorch 2.11, torch.grouped_mm on CPU required 16 bytes alignment which is not |
Contributor
There was a problem hiding this comment.
Can we make it more of a list in the comment, e.g. under the following conditions we cannot use native grouped mm from torch: ...
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
approved these changes
Mar 24, 2026
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
LGTM, aligned with our offline discussion, thanks a lot!
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Mar 27, 2026
…ce#44970) * fix 16 bytes alignement issue * add issue for reference * test fix for non-aligned inputs as well * avoid dims non divisible by 8 for grouped_mm testing * test * style * final fix that works for cpu builds as well * move coment
NielsRogge
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Mar 30, 2026
…ce#44970) * fix 16 bytes alignement issue * add issue for reference * test fix for non-aligned inputs as well * avoid dims non divisible by 8 for grouped_mm testing * test * style * final fix that works for cpu builds as well * move coment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes it once and for all 🙏
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.