Update configuration_Clarify rotary_pct reset behavior in GPTNeoXConfiggpt_neox.py#45025
Closed
layla1824 wants to merge 1 commit intohuggingface:mainfrom
Closed
Update configuration_Clarify rotary_pct reset behavior in GPTNeoXConfiggpt_neox.py#45025layla1824 wants to merge 1 commit intohuggingface:mainfrom
layla1824 wants to merge 1 commit intohuggingface:mainfrom
Conversation
Add note about rotary_pct reset behavior
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gpt_neox |
Member
|
Duplicate of #44985, will close as I am merging the other PR today. It got stale due to CI issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a clarification comment regarding the behavior of rotary_pct.
Currently, rotary_pct may reset to its default value (0.25) after reload due to the use of kwargs.pop.
This note helps developers better understand this behavior.