Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
itazap
force-pushed
the
tok_auto_fallback
branch
from
a91275e to
b65fe63
Compare
ArthurZucker
approved these changes
Mar 31, 2026
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Nice to have thanks for fixing
| ): | ||
| # new model, but we ignore it unless the model type is the same | ||
| tokenizer_class = tokenizer_class_from_name(tokenizer_config_class) | ||
| if tokenizer_class is not None and tokenizer_class.__name__ not in ("TokenizersBackend", "PythonBackend"): |
Collaborator
There was a problem hiding this comment.
IDK if at tthis point PreTrainedTokenizersFast could still be here (remote code?) so maybe include it here?
| return TokenizersBackend.from_pretrained(pretrained_model_name_or_path, *inputs, **kwargs) | ||
| except Exception as e: | ||
| logger.debug(f"Failed to use TokenizersBackend: {e}") | ||
| return TokenizersBackend.from_pretrained(pretrained_model_name_or_path, *inputs, **kwargs) |
Collaborator
There was a problem hiding this comment.
I'm guessing here, we let it fail?
| finally: | ||
| os.chdir(prev_dir) | ||
|
|
||
| @require_sentencepiece |
Collaborator
There was a problem hiding this comment.
ty! can we add one with mock sentencepiece not available!
ArthurZucker
approved these changes
Apr 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
lvliang-intel
pushed a commit
to lvliang-intel/transformers
that referenced
this pull request
Apr 21, 2026
* throw error when conversion required * fix * typo * comment * add test without sentencepiece and add PreTrainedTokenizerFast to class list
artem-spector
pushed a commit
to artem-spector/transformers
that referenced
this pull request
Apr 21, 2026
* throw error when conversion required * fix * typo * comment * add test without sentencepiece and add PreTrainedTokenizerFast to class list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes fallback #44993