fix audio encoder output length formula in qwen3_omni_moe#45088
Closed
knQzx wants to merge 1 commit intohuggingface:mainfrom
Closed
fix audio encoder output length formula in qwen3_omni_moe#45088knQzx wants to merge 1 commit intohuggingface:mainfrom
knQzx wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_omni_moe |
Member
|
hi @knQzx, closing this! It's not wrong, but it's just copying the suggested fix from the original author's PR, which has some issues. We're also trying to discourage "drive-by" PRs on other authors issues until the author confirms they don't want to open one themselves, because it creates a lot of notification spam, especially from agents. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrects the conv output length calculation in _get_feat_extract_output_lengths which was computing wrong values for the audio encoder. fixes #45083