Fix _get_feat_extract_output_lengths in qwen3_omni_moe#45091
Closed
hkc5 wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix _get_feat_extract_output_lengths in qwen3_omni_moe#45091hkc5 wants to merge 1 commit intohuggingface:mainfrom
hkc5 wants to merge 1 commit intohuggingface:mainfrom
Conversation
…PyTorch Conv2d formula
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_omni_moe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the unexpected behaviour of helper function
_get_feat_extract_output_lengthsin qwen3_omni_moe as reported in #45083.Problem
The current implementation incorrectly calculates the output length of the convolutional layers by:
(input_lengths // 100) * 13This does not align with the official PyTorch Conv2d formula.
Fix
Updated the function to correctly calculate the output length based on the PyTorch Conv2d formula:
Files Changed
Fixes #45083