Fix text-to-speech pipeline crash when generation config contains None values#45107
Merged
Rocketknight1 merged 6 commits intohuggingface:mainfrom Apr 8, 2026
Merged
Fix text-to-speech pipeline crash when generation config contains None values#45107Rocketknight1 merged 6 commits intohuggingface:mainfrom
text-to-speech pipeline crash when generation config contains None values#45107Rocketknight1 merged 6 commits intohuggingface:mainfrom
Conversation
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Contributor
Author
|
Hi @ydshieh . Would you please review this PR? Thanks! |
Contributor
Author
|
Hi @Rocketknight1 . Would you please review this PR? Thanks! |
Rocketknight1
approved these changes
Apr 8, 2026
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Yeah, makes sense to me! None values probably do not want to override any existing config settings anyway.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
bigshanedogg
pushed a commit
to bigshanedogg/transformers
that referenced
this pull request
Apr 9, 2026
…None` values (huggingface#45107) fix text-to-audio pipeline config Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
…None` values (huggingface#45107) fix text-to-audio pipeline config Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
text-to-speechpipeline crashes when loading models whosegeneration_configcontains fields set toNone(e.g.use_cache=None). This is becauseTextToAudioPipeline.__init__blindly copies all generation config values into the model config viaconfig.update(gen_config.to_dict()), which triggershuggingface_hub's strict dataclass field validation when aNonevalue is assigned to a typed field (e.g.bool).The fix filters out
Nonevalues before updating the config.Reproduction
Fix