Add full GGUF loading support for GPT‑OSS (fixes #43366)#45116
Closed
sirzechs66 wants to merge 4 commits intohuggingface:mainfrom
Closed
Add full GGUF loading support for GPT‑OSS (fixes #43366)#45116sirzechs66 wants to merge 4 commits intohuggingface:mainfrom
sirzechs66 wants to merge 4 commits intohuggingface:mainfrom
Conversation
91529e7 to
5d4515b
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gpt_oss |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45116&sha=6e2e65 |
Contributor
Author
|
i thought the CI conflicts were something from my end , my apologies please feel free to refer to this pr #45118 it still has some issues but i think are from other unmodified files, any help is appretiated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds full GGUF loading support for GPT‑OSS models (20B/120B). It allows Transformers (and consequently vLLM) to directly load GPT‑OSS GGUF files without falling back to a wrong architecture. The changes include:
GptOssTensorProcessorto handle MoE expert splitting and gate/up interleaving.rope_scaling(YaRN) from flat GGUF metadata.Fixes #43366, supersedes #43757.
Related vLLM issue: vllm-project/vllm#22353
Code Agent Policy
Before submitting
GptOssGgufLoadingTestintests/models/gpt_oss/test_modeling_gpt_oss.py.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Tagging: