Skip to content

Fix PP test_ocr_queries#45123

Merged
vasqu merged 1 commit intomainfrom
fix_pp_test
Mar 30, 2026
Merged

Fix PP test_ocr_queries#45123
vasqu merged 1 commit intomainfrom
fix_pp_test

Conversation

@Rocketknight1
Copy link
Copy Markdown
Member

The test_ocr_queries assertion value was wrong, even at the initial commit! I'm not sure how tests passed at the time but they're failing now in the CI. This PR fixes the target value!

@Rocketknight1 Rocketknight1 marked this pull request as ready for review March 30, 2026 15:48
@Rocketknight1
Copy link
Copy Markdown
Member Author

cc @vasqu since you reviewed the original PR iirc

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: pp_chart2table

@Rocketknight1 Rocketknight1 mentioned this pull request Mar 30, 2026
5 tasks
@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 30, 2026

run-slow: pp_chart2table

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/pp_chart2table"]
quantizations: []

Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first check with run-slow to see if the integration is not somehow broken completely 👀 I'm pretty sure it passed when we added it but maybe we lacked behind main? No idea let's double check first

Careful approval, if everything turns out green (we need to look at the workflow run)

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 91031f92 workflow commit (merge commit)
PR 05bc1ef8 branch commit (from PR)
main 02063e68 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@vasqu vasqu added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 62a8e12 Mar 30, 2026
22 checks passed
@vasqu vasqu deleted the fix_pp_test branch March 30, 2026 16:28
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants