http retries on audio file downloads#45126
Merged
tarekziade merged 5 commits intomainfrom Apr 9, 2026
Merged
Conversation
…dundant exceptions
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
reviewed
Apr 9, 2026
ydshieh
reviewed
Apr 9, 2026
ydshieh
approved these changes
Apr 9, 2026
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
Very nice change!
See DM internally for a nit.
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
* http retries on lib audio file downloads * cleanups: the retry decorator is not http specific and the hub had redundant exceptions * docstrings and sleep assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This patch adds exponential back-off for
load_audio_librosa/load_audio_as/load_audio_torchcodecwhen they try to download a file.
That generic utility is also used within
hub_retrynotice that there were no streaming done before, so I kept the same logic.