Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bert |
… get_diff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This reverts commit fd58eac.
tarekziade
approved these changes
Mar 31, 2026
Collaborator
tarekziade
left a comment
tarekziade
left a comment
There was a problem hiding this comment.
Nice! LGTM. bonus point if we add a small test
…get_diff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Mar 31, 2026
* comment * fix(tests_fetcher): skip files with docstring/comment-only changes in get_diff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Revert "comment" This reverts commit fd58eac. * test(tests_fetcher): add test for docstring-only change exclusion in get_diff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Apr 4, 2026
* comment * fix(tests_fetcher): skip files with docstring/comment-only changes in get_diff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Revert "comment" This reverts commit fd58eac. * test(tests_fetcher): add test for docstring-only change exclusion in get_diff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Really stupid ...
Currently, change a docstring will count as "modified files", then the impacted files and test files to run are computed.
Say, we add a comment to bert, many files impacted (via dependency) then many test files to run.
This PR avoid this waste.