Skip to content

refactor(gpt-oss): rename eager_attention_forward to eager_attention_forward_with_sink#45142

Closed
casinca wants to merge 1 commit intohuggingface:mainfrom
casinca:refactor-gpt-oss-eager-attn-func
Closed

refactor(gpt-oss): rename eager_attention_forward to eager_attention_forward_with_sink#45142
casinca wants to merge 1 commit intohuggingface:mainfrom
casinca:refactor-gpt-oss-eager-attn-func

Conversation

@casinca
Copy link
Copy Markdown
Contributor

@casinca casinca commented Mar 31, 2026

What does this PR do?

Following: This would resolve #45141

For modularity and also linked to this PR #45144. Potentially re-using mulitple eagers for hybrid models (eg MiMo non-sink/sink eager attn)

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: gpt_oss

@Rocketknight1
Copy link
Copy Markdown
Member

Closing this one after comments in #45141!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[refactor] gpt-oss eager_attention_forward for modularity (Ex: models with dual eager attn: sink/no sink)

2 participants