Skip to content

Re-add regex substitutions to the response parsing spec#45166

Merged
vasqu merged 4 commits intomainfrom
parse_response_re_sub
Apr 1, 2026
Merged

Re-add regex substitutions to the response parsing spec#45166
vasqu merged 4 commits intomainfrom
parse_response_re_sub

Conversation

@Rocketknight1
Copy link
Copy Markdown
Member

We didn't think we needed them, but I think we do after all!

@Rocketknight1 Rocketknight1 marked this pull request as ready for review April 1, 2026 14:46
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, trusting you on this, at least looks reasonable on a first quick glance

@Rocketknight1
Copy link
Copy Markdown
Member Author

I'll take responsibility if anything breaks, but it should be very safe with no impact on any code not using the new substitution key!

@Rocketknight1 Rocketknight1 enabled auto-merge April 1, 2026 15:10
@Rocketknight1 Rocketknight1 added this pull request to the merge queue Apr 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026
@vasqu vasqu merged commit c1237d9 into main Apr 1, 2026
30 checks passed
@vasqu vasqu deleted the parse_response_re_sub branch April 1, 2026 15:46
marvinzh pushed a commit to marvinzh/transformers that referenced this pull request Apr 3, 2026
…45166)

* Re-add regex substitutions to the spec

* make fix-repo

* Update the test schema to drop the empty content block

* Trigger tests
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Apr 4, 2026
…45166)

* Re-add regex substitutions to the spec

* make fix-repo

* Update the test schema to drop the empty content block

* Trigger tests
sirzechs66 pushed a commit to sirzechs66/transformers that referenced this pull request Apr 18, 2026
…45166)

* Re-add regex substitutions to the spec

* make fix-repo

* Update the test schema to drop the empty content block

* Trigger tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants