[misc] fix qwen35 tests: correct the text model type and skip reverse_mapping#45173
Merged
Rocketknight1 merged 2 commits intohuggingface:mainfrom Apr 2, 2026
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_5, qwen3_5_moe |
Member
|
run-slow: qwen3_5, qwen3_5_moe |
Contributor
|
This comment contains models: ["models/qwen3_5", "models/qwen3_5_moe"] |
Rocketknight1
approved these changes
Apr 2, 2026
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Happy to approve this one! Those tests were kinda flaky, and I agree that they fit a bit awkwardly here
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
marvinzh
pushed a commit
to marvinzh/transformers
that referenced
this pull request
Apr 3, 2026
…_mapping (huggingface#45173) * tests: skip qwen3.5 reverse mapping for vlm * update
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Apr 4, 2026
…_mapping (huggingface#45173) * tests: skip qwen3.5 reverse mapping for vlm * update
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
…_mapping (huggingface#45173) * tests: skip qwen3.5 reverse mapping for vlm * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed the
qwen3_5/qwen3_5_moereverse-loading tests by correcting the text model type used in the setup, and aligned the reverse-mapping behavior with gemma3n since they are all native multimodal.This also removes the custom qwen3_5_moe_text reverse-loading override, since it was only skipping the
^model.language_modelmapping.