Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Apr 2, 2026
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Good job! Nice unbloating!
Comment on lines
+548
to
+550
| def _equation_coefficients(self, cache_dtype: torch.dtype) -> tuple[int, int, int, int]: | ||
| """Returns (coeff_n, coeff_m, coeff_nm, coeff_mm) for the memory polynomial. Each addend is annotated with | ||
| the tensor it corresponds to in `ContinuousBatchingIOs._setup_static_tensors`. |
| """Largest positive root of a·x² + b·x + c = 0. Falls back to linear when a == 0.""" | ||
| if a == 0: | ||
| return -c / b | ||
| discriminant = b**2 - 4 * a * c |
marvinzh
pushed a commit
to marvinzh/transformers
that referenced
this pull request
Apr 3, 2026
* Bette cache update * alternative cache uodate * Fix paged tests * Update cache computation * Add test * Memory for CB overall * int64 for tensors * Review compliance * Review compliance 2/2 * Style * Fix test
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Apr 4, 2026
* Bette cache update * alternative cache uodate * Fix paged tests * Update cache computation * Add test * Memory for CB overall * int64 for tensors * Review compliance * Review compliance 2/2 * Style * Fix test
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
* Bette cache update * alternative cache uodate * Fix paged tests * Update cache computation * Add test * Memory for CB overall * int64 for tensors * Review compliance * Review compliance 2/2 * Style * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ads minor changes to
cache.update, updates the memory handler with all new features and refactors a few parts of the code to make it more readable.Cache indexing:
Memory handler (cache.py)
Benchmark (continuous_batching_overall.py)
Tests
Performance
Those changes add between 1 and 3% of performance (when not using the block table) depending on the workload. No regressions.
Testing
All tests pass, expect
tests/generation/test_continuous_batching.py::ContinuousBatchingWithAcceleratorTest::test_prefix_sharingwhich is fixed in #45026