Make the cli a top-level package#45181
Draft
tarekziade wants to merge 3 commits intomainfrom
Draft
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45181&sha=742f1f |
tarekziade
force-pushed
the
tarekziade-lazy-cli
branch
from
742f1f9 to
78ac753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
transformersCLI currently does a lot of work before command dispatch. In particular, the top-level entrypoint eagerly importstransformersand CLI subcommands with heavy dependencies, so even simple invocations such astransformers --helpare slower than they should be. (up to 5 seconds on my M5)This PR introduces a lightweight top-level
transformers_clibootstrap package for the public CLI entrypoint. The existing command implementations remain insrc/transformers/cli, but the root command no longer has to import the fulltransformerspackage just to render top-level help or dispatch subcommands lazily.This keeps the change narrowly scoped while giving us a cleaner foundation for future CLI work. In particular it becomes easier to add lightweight commands that do not depend on torch-backed
transformersinternals, and to keep the root CLI path responsive as the command surface grows.